New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle character boundary in search mode #18928

Open

roife wants to merge 1 commit into rust-lang:master from roife:fix-18918

+25 −1

Member

roife commented Jan 12, 2025

I also used Clippy to scan and check usages of slicing in the project, and found that only here could cause a panic.


          fix: handle character boundary in search mode

6349e4f

rustbot added the S-waiting-on-review label

Contributor

ChayimFriedman2 commented Jan 12, 2025

There is another slicing that looks like it may panic in line 305 (let prefix = &candidate[..query.len()];).

But do you know why it panics? We use match_indices(), it should return a correct index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review